yamt commented on a change in pull request #2222:
URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r524192384
##########
File path: arch/sim/include/types.h
##########
@@ -44,6 +44,8 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler_stdint.h>
Review comment:
because
* i'm not comfortable to assume that `__xxx_TYPE__` is always available.
* predefined macros are not obvious when reading the code.
* this way we can easily notice possible mistakes (like using a compiler
which is configured in an incompatible way)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
