jrhenderson1988 commented on PR #3026: URL: https://github.com/apache/iggy/pull/3026#issuecomment-4128945510
Thank you both for the reviews. @ex172000 I think I've fixed the comment copy/paste issue. I could only see one occurrence. @mmodzelewski I've refactored the logic to keep the complexity of the method down below the gates. I had a look to see if there was something we could use from Netty to get it to simulate a connection failure but it doesn't look like there was anything. I did manage to surface a faillure by making it connect to 192.0.2.1 with a 100ms timeout and it threw an exception: ``` connection timed out after 100 ms: /192.0.2.1:8080 io.netty.channel.ConnectTimeoutException: connection timed out after 100 ms: /192.0.2.1:8080 ``` Not sure if that's something we'd like to wrap and throw an Iggy based exception instead. What do you think? Let me know if you would like any further changes. If not, this is ready to review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
