mmodzelewski commented on PR #3026: URL: https://github.com/apache/iggy/pull/3026#issuecomment-4124889237
@ex172000 did you mean to add any comments to the code? @jrhenderson1988 let's try to refactor the code to keep the existing gate levels. Regarding the connection timeout, from our side it is mostly passing an argument, the heavy lifting is on the netty's side and I'd expect it is well tested. I wonder if netty has any test utils that would help us at least verify if we handle the timeout error correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
