jrhenderson1988 commented on code in PR #3026:
URL: https://github.com/apache/iggy/pull/3026#discussion_r2991617459
##########
foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncIggyTcpClientBuilder.java:
##########
@@ -229,6 +229,9 @@ public AsyncIggyTcpClient build() {
if (connectionPoolSize != null && connectionPoolSize <= 0) {
throw new IggyInvalidArgumentException("Connection pool size
cannot by 0 or negative");
}
+ if (connectionTimeout != null &&
(connectionTimeout.equals(Duration.ZERO) || connectionTimeout.isNegative())) {
Review Comment:
Good idea - I've added a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
