jrhenderson1988 commented on code in PR #3026:
URL: https://github.com/apache/iggy/pull/3026#discussion_r2984768116
##########
foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncIggyTcpClient.java:
##########
@@ -126,7 +127,7 @@ public class AsyncIggyTcpClient {
* @param port the server port
*/
public AsyncIggyTcpClient(String host, int port) {
- this(host, port, null, null, null, null, null, null, false,
Optional.empty());
+ this(host, port, null, null, null, null, null, null, null, false,
Optional.empty());
Review Comment:
I am unsure if this class is considered to be part of the public API and
whether changing the constructor would be considered a breaking change. If so,
I may need to re-think this.
##########
foreign/java/java-sdk/src/main/java/org/apache/iggy/client/async/tcp/AsyncIggyTcpClientBuilder.java:
##########
@@ -238,6 +241,7 @@ public AsyncIggyTcpClient build() {
username,
password,
connectionTimeout,
+ acquireTimeout,
Review Comment:
Before my change, we were passing `connectionTimeout` to the
`acquireTimeout` parameter and there was no `connectionTimeout`. I've since
added a `connectionTimeout` and made sure that the arguments line up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
