jrhenderson1988 opened a new pull request, #3026: URL: https://github.com/apache/iggy/pull/3026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #3010 ## Rationale The connection timeout is a value supported by the builders of both the async and blocking TCP builders, but the clients that they build do not properly apply the connection timeout. ## What changed? Passes through the connection timeout into the `AsyncIggyTcpClient` and the subsequent `AsyncTcpConnection` where it is used in the bootstrap given to the connection pool. The `ChannelOption.CONNECT_TIMEOUT_MILLIS` value is set with the value of the connection timeout in milliseconds, falling back to the 3000ms value that was used previously if it's not set. <!-- 2-4 sentences. Problem first (before), then solution (after). GOOD: "Messages were unavailable when background message_saver committed the journal and started async disk I/O before completion. Polling during this window found neither journal nor disk data. The fix freezes journal batches in the in-flight buffer before async persist." GOOD: "When many small messages accumulate in the journal, the flush passes thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)." BAD: - Walls of text - "This PR adds..." (we can see the diff) --> ## Local Execution - Passed - Pre-commit hooks ran <!-- You must run your code locally before submitting. "Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed. Did you have `prek` installed? It runs automatically on commit and covers all project languages. See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md). --> ## AI Usage - Claude was used to ask some questions - Jetbrains full line completion local model was used for autocomplete - I can explain all code and full test suite was run to verify that everything still works <!-- If AI tools were used, please answer: 1. Which tools? (e.g., GitHub Copilot, Claude, ChatGPT) 2. Scope of usage? (e.g., autocomplete, generated functions, entire implementation) 3. How did you verify the generated code works correctly? 4. Can you explain every line of the code if asked? If no AI tools were used, write "None" or delete this section. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
