hudi-agent commented on code in PR #20130:
URL: https://github.com/apache/hudi/pull/20130#discussion_r4137646464
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkInternalSchemaConverter.java:
##########
@@ -325,6 +326,22 @@ private static DataType constructSparkSchemaFromType(Type
type) {
}
}
+ private static void putDecimalOrNull(
Review Comment:
🤖 nit: `putDecimalOrNull` doesn't say that it throws in ANSI mode. Could you
rename it to something like `putDecimalWithOverflowCheck`, or add a short
Javadoc explaining the null-vs-throw behavior depending on
`spark.sql.ansi.enabled`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
