ashokraminedi commented on code in PR #20130:
URL: https://github.com/apache/hudi/pull/20130#discussion_r4137886519
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkInternalSchemaConverter.java:
##########
@@ -325,6 +326,22 @@ private static DataType constructSparkSchemaFromType(Type
type) {
}
}
+ private static void putDecimalOrNull(
Review Comment:
Good point. Renamed the helper to `putDecimalWithOverflowCheck` to make it
clear that overflow handling may either write NULL or throw depending on ANSI
mode. No behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
