ashokraminedi commented on code in PR #20130:
URL: https://github.com/apache/hudi/pull/20130#discussion_r4137841746
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkInternalSchemaConverter.java:
##########
@@ -349,9 +349,13 @@ private static boolean
convertIntLongType(WritableColumnVector oldV, WritableCol
} else if (newType instanceof StringType) {
newV.putByteArray(i, getUTF8Bytes((isInt ? oldV.getInt(i) :
oldV.getLong(i)) + ""));
} else if (newType instanceof DecimalType) {
+ DecimalType decimalType = (DecimalType) newType;
Decimal oldDecimal = Decimal.apply(isInt ? oldV.getInt(i) :
oldV.getLong(i));
- oldDecimal.changePrecision(((DecimalType) newType).precision(),
((DecimalType) newType).scale());
- newV.putDecimal(i, oldDecimal, ((DecimalType) newType).precision());
+ if (oldDecimal.changePrecision(decimalType.precision(),
decimalType.scale())) {
+ newV.putDecimal(i, oldDecimal, decimalType.precision());
Review Comment:
Agreed. I updated the PR description to `Part of #20108` rather than `Closes
#20108`.
This PR stays focused on the DECIMAL precision-overflow paths, now covering
the affected INT/LONG, FLOAT, DOUBLE, and STRING conversions. The unsupported
Boolean, Byte, Short, Binary, and Timestamp fallback remains separate work
under #20108.
The additional FLOAT/DOUBLE/STRING overflow cases found during this
investigation are tracked in #20143, which this PR now addresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
