ashokraminedi commented on code in PR #20130:
URL: https://github.com/apache/hudi/pull/20130#discussion_r4137811674
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/common/TestVectorizedReadWithSchemaEvolution.scala:
##########
@@ -66,5 +66,44 @@ class TestVectorizedReadWithSchemaEvolution extends
HoodieSparkSqlTestBase {
}
}
}
+
+ test(s"Test INT to DECIMAL schema evolution with precision overflow for
$tableType table") {
Review Comment:
You're right — the MOR leg wasn't exercising the changed vectorized
conversion path here.
I updated the new decimal-overflow regression tests in `889b09ac6c27` to be
COW-only rather than keeping MOR as part of the regression coverage. I also
updated the PR description to avoid attributing the incorrect-value behavior to
the MOR path.
Thanks for pointing out the `enableVectorizedRead = false` path here; that
clarified why the MOR case could pass independently of this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
