Re: [PR] [#6566] improvement(core): Add the cache mechanism for metalake and use cache to load `in-use` information. [gravitino]

[via GitHub]

mchades commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1975335821


##########
core/src/main/java/org/apache/gravitino/metalake/MetalakeManager.java:
##########
@@ -253,7 +289,7 @@ public BaseMetalake alterMetalake(NameIdentifier ident, 
MetalakeChange... change
               throw new MetalakeNotInUseException(
                   "Metalake %s is not in use, please enable it first", ident);
             }
-
+            METALAKE_CACHE.invalidate(ident);

Review Comment:
   Can the result be cached after updating?



##########
core/src/main/java/org/apache/gravitino/metalake/MetalakeManager.java:
##########
@@ -103,10 +132,12 @@ public static void checkMetalake(NameIdentifier ident, 
EntityStore store)
   public static boolean metalakeInUse(EntityStore store, NameIdentifier ident)
       throws NoSuchMetalakeException {
     try {
-      BaseMetalake metalake = store.get(ident, EntityType.METALAKE, 
BaseMetalake.class);
+      BaseMetalake metalake = METALAKE_CACHE.getIfPresent(ident);
+      if (metalake == null) {
+        metalake = store.get(ident, EntityType.METALAKE, BaseMetalake.class);
+      }

Review Comment:
   why not cache the result after getting it from the store?



##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -260,7 +260,7 @@ private ModelCatalog asModels() {
 
   private final Config config;
 
-  @VisibleForTesting final Cache<NameIdentifier, CatalogWrapper> catalogCache;
+  @VisibleForTesting static Cache<NameIdentifier, CatalogWrapper> catalogCache;

Review Comment:
   should named `CATALOG_CACHE`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org