Re: [PR] [#6566] improvement(core): Add the cache mechanism for matalake and use cache to load `in-use` information. [gravitino]

[via GitHub]

jerryshao commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1974902287


##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -791,12 +791,17 @@ private static boolean catalogInUse(EntityStore store, 
NameIdentifier ident)
 
   private static boolean getCatalogInUseValue(EntityStore store, 
NameIdentifier catalogIdent) {
     try {
-      CatalogEntity catalogEntity =
-          store.get(catalogIdent, EntityType.CATALOG, CatalogEntity.class);
+      CatalogWrapper wrapper = catalogCache.getIfPresent(catalogIdent);
+      CatalogEntity catalogEntity;
+      if (wrapper != null) {
+        catalogEntity = wrapper.catalog.entity();
+      } else {
+        catalogEntity = store.get(catalogIdent, EntityType.CATALOG, 
CatalogEntity.class);

Review Comment:
   Shall we put this `catalogEntity` in cache? Besides, can we use loadcatalog 
directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org