Re: [PR] [#6566] improvement(core): Add the cache mechanism for metalake and use cache to load `in-use` information. [gravitino]

[via GitHub]

mchades commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1975440584


##########
core/src/main/java/org/apache/gravitino/metalake/MetalakeManager.java:
##########
@@ -103,10 +132,12 @@ public static void checkMetalake(NameIdentifier ident, 
EntityStore store)
   public static boolean metalakeInUse(EntityStore store, NameIdentifier ident)
       throws NoSuchMetalakeException {
     try {
-      BaseMetalake metalake = store.get(ident, EntityType.METALAKE, 
BaseMetalake.class);
+      BaseMetalake metalake = METALAKE_CACHE.getIfPresent(ident);
+      if (metalake == null) {
+        metalake = store.get(ident, EntityType.METALAKE, BaseMetalake.class);
+      }

Review Comment:
    after the user alters the metalake, then load schema/table directly without 
list/get the metalake, the cache never be hitting, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org