Re: [PR] [#6566] improvement(core): Add the cache mechanism for matalake and use cache to load `in-use` information. [gravitino]

[via GitHub]

jerryshao commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1974896684


##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -260,7 +260,7 @@ private ModelCatalog asModels() {
 
   private final Config config;
 
-  @VisibleForTesting final Cache<NameIdentifier, CatalogWrapper> catalogCache;
+  @VisibleForTesting static Cache<NameIdentifier, CatalogWrapper> catalogCache;

Review Comment:
   Why do we make it static? I assume there will be only one `CatalogManager`, 
so there should be only one `catalogCache`, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org