yuqi1129 commented on code in PR #6569:
URL: https://github.com/apache/gravitino/pull/6569#discussion_r1974902705
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -260,7 +260,7 @@ private ModelCatalog asModels() {
private final Config config;
- @VisibleForTesting final Cache<NameIdentifier, CatalogWrapper> catalogCache;
+ @VisibleForTesting static Cache<NameIdentifier, CatalogWrapper> catalogCache;
Review Comment:
> Why do we make it static?
The method check `catalogInUse` and `metalakeInUse` are all static. If we
want to use cache for them, we need to change it to `static`
> assume there will be only one CatalogManager, so there should be only one
catalogCache, right?
Yes, there will be only one cache and all catalogs shares the same instance,
It's not a big problem I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
