jtuglu1 commented on code in PR #19286: URL: https://github.com/apache/druid/pull/19286#discussion_r3122722509
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java: ########## Review Comment: For context, before your [change](https://github.com/apache/druid/commit/5f37b7b5b74c98b341588b95daae21b1f38ca01d), the [line] (https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java#L278) the `LagBasedAutoscaler` used to emit the required task count (even if this was above the maximum value). ########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScaler.java: ########## Review Comment: For context, before your [change](https://github.com/apache/druid/commit/5f37b7b5b74c98b341588b95daae21b1f38ca01d), the [line](https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java#L278) the `LagBasedAutoscaler` used to emit the required task count (even if this was above the maximum value). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
