jtuglu1 commented on code in PR #19286:
URL: https://github.com/apache/druid/pull/19286#discussion_r3128816880
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScalerConfig.java:
##########
@@ -90,14 +91,15 @@ public CostBasedAutoScalerConfig(
: DEFAULT_SCALE_ACTION_PERIOD_MILLIS;
this.minTriggerScaleActionFrequencyMillis = Configs.valueOrDefault(
minTriggerScaleActionFrequencyMillis,
- DEFAULT_MIN_TRIGGER_SCALE_ACTION_FREQUENCY_MILLIS
+ DEFAULT_SCALE_ACTION_PERIOD_MILLIS / 2
Review Comment:
Ok, the above change isn't changing anything from existing behavior (just
rewriting to remove the `DEFAULT_MIN_TRIGGER_SCALE_ACTION_FREQUENCY_MILLIS`). I
can change that I guess
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScalerConfig.java:
##########
@@ -90,14 +91,15 @@ public CostBasedAutoScalerConfig(
: DEFAULT_SCALE_ACTION_PERIOD_MILLIS;
this.minTriggerScaleActionFrequencyMillis = Configs.valueOrDefault(
minTriggerScaleActionFrequencyMillis,
- DEFAULT_MIN_TRIGGER_SCALE_ACTION_FREQUENCY_MILLIS
+ DEFAULT_SCALE_ACTION_PERIOD_MILLIS / 2
Review Comment:
Ok, the above change isn't changing anything from existing behavior (just
rewriting to remove the `DEFAULT_MIN_TRIGGER_SCALE_ACTION_FREQUENCY_MILLIS`
dependency). I can change that I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
