github-advanced-security[bot] commented on code in PR #19286:
URL: https://github.com/apache/druid/pull/19286#discussion_r3126662976
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/supervisor/autoscaler/LagBasedAutoScalerConfigTest.java:
##########
@@ -278,11 +299,256 @@
true,
null,
null,
+ null,
+ null,
0.5
);
Assert.assertEquals(Double.valueOf(0.5), config.getStopTaskCountRatio());
}
+ @Test
+ public void testScaleDelayFallback() throws Exception
+ {
+ // Neither minScaleUpDelay nor minScaleDownDelay set: both fall back to
minTriggerScaleActionFrequencyMillis
+ LagBasedAutoScalerConfig baseOnly = new LagBasedAutoScalerConfig(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ 10,
+ null,
+ 1,
+ null,
+ null,
+ false,
+ 60000L,
+ null,
+ null,
+ null,
+ null
+ );
+ Assert.assertEquals(60000L,
baseOnly.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.millis(60000), baseOnly.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(60000),
baseOnly.getMinScaleDownDelay());
+
+ // Only minScaleUpDelay set
+ LagBasedAutoScalerConfig upOnly = new LagBasedAutoScalerConfig(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ 10,
+ null,
+ 1,
+ null,
+ null,
+ false,
+ 60000L,
+ Duration.millis(15000),
+ null,
+ null,
+ null
+ );
+ Assert.assertEquals(Duration.millis(15000), upOnly.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(60000), upOnly.getMinScaleDownDelay());
+
+ // Only minScaleDownDelay set
+ LagBasedAutoScalerConfig downOnly = new LagBasedAutoScalerConfig(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ 10,
+ null,
+ 1,
+ null,
+ null,
+ false,
+ 60000L,
+ null,
+ Duration.millis(30000),
+ null,
+ null
+ );
+ Assert.assertEquals(Duration.millis(60000), downOnly.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(30000),
downOnly.getMinScaleDownDelay());
+
+ // Both set: serde roundtrip preserves values
+ LagBasedAutoScalerConfig bothSet = new LagBasedAutoScalerConfig(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ 10,
+ null,
+ 1,
+ null,
+ null,
+ false,
+ null,
+ Duration.millis(15000),
+ Duration.millis(30000),
+ null,
+ null
+ );
+ Assert.assertEquals(Duration.millis(15000), bothSet.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(30000),
bothSet.getMinScaleDownDelay());
+ LagBasedAutoScalerConfig roundTripped = OBJECT_MAPPER.readValue(
+ OBJECT_MAPPER.writeValueAsString(bothSet),
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(bothSet, roundTripped);
+ }
+
+ @Test
+ @SuppressWarnings("deprecation")
+ public void testScaleDelayFallbackViaSerde() throws Exception
+ {
+ // JSON with only minTriggerScaleActionFrequencyMillis (no Duration
fields):
+ // both getMinScaleUpDelay() and getMinScaleDownDelay() should fall back
to it.
+ String json =
"{\"taskCountMax\":10,\"taskCountMin\":1,\"minTriggerScaleActionFrequencyMillis\":45000}";
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(json,
LagBasedAutoScalerConfig.class);
+ Assert.assertEquals(45000L,
config.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.millis(45000), config.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(45000), config.getMinScaleDownDelay());
+
+ // JSON with minTriggerScaleActionFrequencyMillis and only minScaleUpDelay:
+ // getMinScaleUpDelay() should return the explicit value;
getMinScaleDownDelay() falls back.
+ String jsonUpOnly = "{\"taskCountMax\":10,\"taskCountMin\":1,"
+ + "\"minTriggerScaleActionFrequencyMillis\":45000,"
+ + "\"minScaleUpDelay\":\"PT10S\"}";
+ LagBasedAutoScalerConfig configUpOnly =
OBJECT_MAPPER.readValue(jsonUpOnly, LagBasedAutoScalerConfig.class);
+ Assert.assertEquals(Duration.standardSeconds(10),
configUpOnly.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(45000),
configUpOnly.getMinScaleDownDelay());
+ }
+
+ @Test
+ @SuppressWarnings("deprecation")
+ public void testMinTriggerScaleActionFrequencyMillisSerdeCompat() throws
Exception
+ {
+ final long defaultMinTriggerMillis = 600_000L;
+
+ // Backwards-compat: nothing set -> deprecated field gets its default and
both direction
+ // delays fall back to it.
+ {
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(
+ "{\"taskCountMax\":10,\"taskCountMin\":1}",
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(defaultMinTriggerMillis,
config.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.millis(defaultMinTriggerMillis),
config.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(defaultMinTriggerMillis),
config.getMinScaleDownDelay());
+ assertRoundTrips(config);
+ }
+
+ // Backwards-compat: legacy spec sets only the deprecated field. Both
direction delays fall
+ // back to it.
+ {
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(
+
"{\"taskCountMax\":10,\"taskCountMin\":1,\"minTriggerScaleActionFrequencyMillis\":900000}",
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(900_000L,
config.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.millis(900_000),
config.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(900_000),
config.getMinScaleDownDelay());
+ assertRoundTrips(config);
+ }
+
+ // Forwards-compat: direction delays set, deprecated field omitted.
Deprecated field defaults.
+ {
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(
+ "{\"taskCountMax\":10,\"taskCountMin\":1,"
+ + "\"minScaleUpDelay\":\"PT2M\",\"minScaleDownDelay\":\"PT15M\"}",
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(defaultMinTriggerMillis,
config.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.standardMinutes(2),
config.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.standardMinutes(15),
config.getMinScaleDownDelay());
+ assertRoundTrips(config);
+ }
+
+ // Forwards-compat: deprecated field AND direction delays set (overlapping
migration window).
+ // Direction delays win for their own direction; the deprecated field is
preserved.
+ {
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(
+ "{\"taskCountMax\":10,\"taskCountMin\":1,"
+ + "\"minTriggerScaleActionFrequencyMillis\":900000,"
+ + "\"minScaleUpDelay\":\"PT2M\",\"minScaleDownDelay\":\"PT15M\"}",
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(900_000L,
config.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.standardMinutes(2),
config.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.standardMinutes(15),
config.getMinScaleDownDelay());
+ assertRoundTrips(config);
+ }
+
+ // Mixed: only minScaleUpDelay + deprecated field set. Down falls back to
the deprecated field.
+ {
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(
+ "{\"taskCountMax\":10,\"taskCountMin\":1,"
+ + "\"minTriggerScaleActionFrequencyMillis\":900000,"
+ + "\"minScaleUpDelay\":\"PT2M\"}",
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(900_000L,
config.getMinTriggerScaleActionFrequencyMillis());
+ Assert.assertEquals(Duration.standardMinutes(2),
config.getMinScaleUpDelay());
+ Assert.assertEquals(Duration.millis(900_000),
config.getMinScaleDownDelay());
+ assertRoundTrips(config);
+ }
+
+ // Mixed: only minScaleDownDelay + deprecated field set. Up falls back to
the deprecated field.
+ {
+ LagBasedAutoScalerConfig config = OBJECT_MAPPER.readValue(
+ "{\"taskCountMax\":10,\"taskCountMin\":1,"
+ + "\"minTriggerScaleActionFrequencyMillis\":900000,"
+ + "\"minScaleDownDelay\":\"PT15M\"}",
+ LagBasedAutoScalerConfig.class
+ );
+ Assert.assertEquals(900_000L,
config.getMinTriggerScaleActionFrequencyMillis());
Review Comment:
## CodeQL / Deprecated method or constructor invocation
Invoking
[LagBasedAutoScalerConfig.getMinTriggerScaleActionFrequencyMillis](1) should be
avoided because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/11115)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
