Fly-Style commented on code in PR #19286:
URL: https://github.com/apache/druid/pull/19286#discussion_r3128742939
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScalerConfig.java:
##########
@@ -90,14 +91,15 @@ public CostBasedAutoScalerConfig(
: DEFAULT_SCALE_ACTION_PERIOD_MILLIS;
this.minTriggerScaleActionFrequencyMillis = Configs.valueOrDefault(
minTriggerScaleActionFrequencyMillis,
- DEFAULT_MIN_TRIGGER_SCALE_ACTION_FREQUENCY_MILLIS
+ DEFAULT_SCALE_ACTION_PERIOD_MILLIS / 2
Review Comment:
I realized that it should be equal to `DEFAULT_SCALE_ACTION_PERIOD_MILLIS`.
That was my mistake.
In fact, here we're trying to scale twice as often as we are trying to
compute new `taskCount`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
