xinyiZzz commented on a change in pull request #8322:
URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r820212845
##########
File path: be/src/exprs/expr_context.cpp
##########
@@ -371,10 +376,11 @@ Status ExprContext::get_const_value(RuntimeState* state,
Expr& expr, AnyVal** co
StringVal* sv = reinterpret_cast<StringVal*>(*const_val);
if (!sv->is_null && sv->len > 0) {
// Make sure the memory is owned by this evaluator.
- char* ptr_copy =
reinterpret_cast<char*>(_pool->try_allocate(sv->len));
+ Status rst;
+ char* ptr_copy =
reinterpret_cast<char*>(_pool->try_allocate(sv->len, &rst));
if (ptr_copy == nullptr) {
- return _pool->mem_tracker()->MemLimitExceeded(
- state, "Could not allocate constant string value",
sv->len);
+ RETURN_ALLOC_LIMIT_EXCEEDED(_pool->mem_tracker(), state,
Review comment:
The difference is the number of parameters, which is not very well named.
I try to unify with variadic macros.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
