xinyiZzz commented on a change in pull request #8322:
URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r820504386
##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -410,11 +411,12 @@ Status ScrollParser::fill_tuple(const TupleDescriptor*
tuple_desc, Tuple* tuple,
}
}
size_t val_size = val.length();
- char* buffer =
reinterpret_cast<char*>(tuple_pool->try_allocate_unaligned(val_size));
+ Status rst;
+ char* buffer =
reinterpret_cast<char*>(tuple_pool->try_allocate_unaligned(val_size, &rst));
Review comment:
There are so many places to call MemPool allocate, "return Status and
use buffer as parameter" will cause a lot of changes, so your suggestion is
whether to change it.
The purpose of getting the status here is to print out the real reason of
allocate failure externally, such as the details of tracker exceed, not just
the location of the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
