xinyiZzz commented on a change in pull request #8322:
URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r818962037



##########
File path: be/src/exec/hash_table.cpp
##########
@@ -244,7 +244,7 @@ void HashTable::grow_node_array() {
     _alloc_list.push_back(_current_nodes);
     _end_list.push_back(_current_nodes + alloc_size);
 
-    _mem_tracker->Consume(alloc_size);
+    _mem_tracker->consume(alloc_size);

Review comment:
       @yiguolei  I have done something similar with reference to clickhouse to 
automatically count memory usage via TCMalloc Hook
   PR: https://github.com/apache/incubator-doris/pull/7198
   But this PR is too big, so I was advised to split the commit =_=
   
   Different from Jemalloc, overloading the TCMalloc new/delete operator needs 
to invade the source code of TCMalloc, so it is implemented by Hook;




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to