xinyiZzz commented on a change in pull request #8322: URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r820210536
########## File path: be/src/exec/es/es_scroll_parser.cpp ########## @@ -410,11 +411,12 @@ Status ScrollParser::fill_tuple(const TupleDescriptor* tuple_desc, Tuple* tuple, } } size_t val_size = val.length(); - char* buffer = reinterpret_cast<char*>(tuple_pool->try_allocate_unaligned(val_size)); + Status rst; + char* buffer = reinterpret_cast<char*>(tuple_pool->try_allocate_unaligned(val_size, &rst)); Review comment: is to be consistent with the previous interface, It seems that what you said is more common, I will change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org