xinyiZzz commented on a change in pull request #8322:
URL: https://github.com/apache/incubator-doris/pull/8322#discussion_r823686866



##########
File path: be/src/exec/olap_scan_node.h
##########
@@ -244,6 +244,7 @@ class OlapScanNode : public ScanNode {
     TResourceInfo* _resource_info;
 
     int64_t _buffered_bytes;
+    std::shared_ptr<MemTracker> _scanner_mem_tracker;

Review comment:
       done
   _scanner_mem_tracker replaces the previous 
runtime_state->fragment_mem_tracker(), both of which are also used to count the 
memory of OlapScanner.
   The difference is that,
   1. The parent of runtime_state->fragment_mem_tracker() is 
process_mem_tracker, which is used in segment_reader of segmentV1 to determine 
whether OlapScanner exceeds the mem limit.
   2. The parent of _scanner_mem_tracker is query_mem_tracker, which removes 
the logic of OlapScanner mem limit exceed in segment_reader.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to