ustcweizhou commented on a change in pull request #3932: Prevent overflow and
null pointer on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#discussion_r388762987
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -1533,7 +1536,7 @@ protected void writeBatches(InfluxDB influxDbConnection,
String dbName, List<Poi
* The considered disk stats are the following: bytes read, bytes write,
IO read, and IO write.
*/
protected boolean
isCurrentVmDiskStatsDifferentFromPrevious(VmDiskStatisticsVO
previousVmDiskStats, VmDiskStatisticsVO currentVmDiskStats) {
- if (previousVmDiskStats != null) {
Review comment:
@GabrielBrascher it looks currentVmDiskStats is not null
https://github.com/apache/cloudstack/blob/9a1486fdebc3d4cfd17d581ec1b66fbd9c3a4bcd/server/src/main/java/com/cloud/server/StatsCollector.java#L735-L746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
