[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3932: Prevent overflow and null pointer on StatsCollector.java

[GitBox]

GabrielBrascher commented on a change in pull request #3932: Prevent overflow 
and null pointer on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#discussion_r387705945
 
 

 ##########
 File path: server/src/main/java/com/cloud/server/StatsCollector.java
 ##########
 @@ -454,8 +456,9 @@ protected void init(Map<String, String> configs) {
             s_logger.warn("Usage stats job aggregation range is to small, 
using the minimum value of " + UsageUtils.USAGE_AGGREGATION_RANGE_MIN);
             _usageAggregationRange = UsageUtils.USAGE_AGGREGATION_RANGE_MIN;
         }
-        _diskStatsUpdateExecutor.scheduleAtFixedRate(new 
VmDiskStatsUpdaterTask(), (endDate - System.currentTimeMillis()), 
(_usageAggregationRange * 60 * 1000),
 
 Review comment:
   Potential overflow in 2 Values before it is converted to long by use in an 
invocation context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services