[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3932: Prevent overflow and null pointer on StatsCollector.java

[GitBox]

GabrielBrascher commented on a change in pull request #3932: Prevent overflow 
and null pointer on StatsCollector.java
URL: https://github.com/apache/cloudstack/pull/3932#discussion_r387706608
 
 

 ##########
 File path: server/src/main/java/com/cloud/server/StatsCollector.java
 ##########
 @@ -1209,7 +1212,7 @@ private String getAutoscaleAction(HashMap<Long, Double> 
avgCounter, long groupId
             for (AutoScaleVmGroupPolicyMapVO asVmgPmap : listMap) {
                 AutoScalePolicyVO policyVO = 
_asPolicyDao.findById(asVmgPmap.getPolicyId());
                 if (policyVO != null) {
-                    Integer quitetime = policyVO.getQuietTime();
 
 Review comment:
   The variable 'quitetime' is only assigned values of primitive type and is 
never 'null', but it is declared with the boxed type 'Integer'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services