GabrielBrascher commented on issue #3932: Prevent overflow on StatsCollector.java URL: https://github.com/apache/cloudstack/pull/3932#issuecomment-596484976 @borisstoyanov the overflow is not something that will happen easily; however, the code is there and it still something that might happen one day depending on the value stored at `_usageAggregationRange`. The operation that I extracted can result in an overflow as it is an **integer** operation stored in an **integer** _memory_ (and then after storing it as an integer it is cast into a long). I extracted it into a `long = int * Long`, which prevents a overflow as it is not an integer operation anymore but converted into a long operation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
