On Thu, May 28, 2020 at 5:17 PM Gallop, Russell <russell.gal...@sony.com> wrote:
> Hi Sam, > > > > Thanks for looking at this. You could use something like in clang/ > ./unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp: > > > > if (llvm::Triple(llvm::sys::getDefaultTargetTriple()).isPS4()) > > return; // PS4 does not support fastcall. > Thanks - we'd really like to disable testing rather than make the tests spuriously pass though. This test failure does reflect a clangd that doesn't work properly: it should always be able to parse "throw" statements unless explicitly directed otherwise. However it doesn't really make sense to run clangd on a PS4 so this isn't a bug we're likely to fix. > > > Regards > > Russ > > > > > > *From:* Sam McCall <sammcc...@google.com> > *Sent:* 28 May 2020 15:55 > *To:* reviews+d78454+public+f260770db3c29...@reviews.llvm.org > *Cc:* Adam Czachorowski <ada...@google.com>; Gallop, Russell < > russell.gal...@sony.com>; Ilya Biryukov <iu.biryu...@gmail.com>; Fangrui > Song <mask...@google.com>; Jan Korous <jkor...@apple.com>; > mgrang.1...@gmail.com; Alex L <arpha...@gmail.com>; Kadir Çetinkaya < > kadir...@google.com>; Utkarsh Saxena <u...@google.com>; cfe-commits < > cfe-commits@lists.llvm.org>; Theko Lekena <mlek...@skidmore.edu>; Nicolas > Lesser <blitzrak...@gmail.com>; Han Shen <shen...@google.com>; Haojian Wu > <hok...@google.com> > *Subject:* Re: [PATCH] D78454: [clangd] Highlight related control flow. > > > > On Thu, May 28, 2020 at 4:35 PM Russell Gallop via Phabricator < > revi...@reviews.llvm.org> wrote: > > russell.gallop added a comment. > > Hi Sam, > > It looks like this is causing a failure on the Windows PS4 buildbot: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/32606 > > Please could you take a look? PS4 target disables RTTI, hence exceptions, > by default so it is probably related to that. > > Thanks! > > Hmm, the clangd tests are supposed to be disabled on PS4 for exactly these > sorts of reasons. It looks like that's only working for shell tests, not > gtests though. > > Lit config is a tangled mess... is there an #ifdef we can use to disable > just that test on PS4 until I get this sorted out? > > > > > Thanks > Russ > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D78454/new/ > > https://reviews.llvm.org/D78454 > > > > > > ********************************************************************** > This email and any files transmitted with it are confidential and intended > solely for the use of the individual or entity to whom they are addressed. > If you have received this email in error please notify > siee.postmas...@sony.com > This footnote also confirms that this email message has been checked for > all known viruses. > Sony Interactive Entertainment Europe Limited > Registered Office: 10 Great Marlborough Street, London W1F 7LP, United > Kingdom > Registered in England: 3277793 > ********************************************************************** > > P* Please consider the environment before printing this e-mail* >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
