sammccall marked 3 inline comments as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/XRefs.cpp:907
+ // Highlight the loop keyword itself.
+ Result.push_back(P->ASTNode.getSourceRange().getBegin());
+ break;
----------------
adamcz wrote:
> nit: in a do {...} while(...) case, would we want to highlight both keywords?
>
> (doesn't seem very important, feel free to ignore)
Yeah, I just left a comment for this. You're right... but do-while is pretty
rare and the code is fairly awkward. Let's see if anyone ever mentions it :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78454/new/
https://reviews.llvm.org/D78454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
