Hi Henry, On 3/7/24 7:54 PM, Henry Wang wrote: > Currently direct mapped domain is only supported by the Arm > architecture at the domain creation time by setting the CDF_directmap > flag. There is not a need for every non-Arm architecture, i.e. x86, > RISC-V and PPC, to define a stub is_domain_direct_mapped() in arch > header. > > Move is_domain_direct_mapped() to a centralized place at xen/domain.h > and evaluate CDF_directmap for non-Arm architecture to 0. > > Signed-off-by: Henry Wang <xin.wa...@amd.com>
Regardless of whether or not you decide to go with the centralized ifdef approach suggested by Michal, consider the PPC parts: Acked-by: Shawn Anastasio <sanasta...@raptorengineering.com> Thanks, Shawn