Hi Michal,
On 3/8/2024 4:18 PM, Michal Orzel wrote:
Hi Henry,
On 08/03/2024 02:54, Henry Wang wrote:
Currently on Arm there are 4 functions to allocate memory as domain
RAM at boot time for different types of domains:
(1) allocate_memory(): To allocate memory for Dom0less DomUs that
do not use static memory.
(2) allocate_static_memory(): To allocate memory for Dom0less DomUs
that use static memory.
(3) allocate_memory_11(): To allocate memory for Dom0.
(4) assign_static_memory_11(): To allocate memory for Dom0less DomUs
that use static memory and directmapped.
To keep consistency between the names and the in-code comment on top
of the functions, rename assign_static_memory_11() to
allocate_static_memory_11(). No functional change intended.
There was a reason for this naming. The function is called assign_ and not
allocate_ because
there is no allocation done inside. The function maps specified host regions to
guest regions.
Refer:
https://lore.kernel.org/xen-devel/20220214031956.3726764-6-penny.zh...@arm.com/
Emmm I indeed had the same idea and thought there should be a reason
about the naming, but at the same time still misguided by the in-code
comment on top of the function saying "Allocate static memory as RAM for
one specific domain d." :/
I guess I will either simply drop this patch or correct the above
in-code comment (which I am not sure if it is worthwhile for an
independent patch). Anyway, thanks for the info!
Kind regards,
Henry
~Michal
