Hi Henry, On 08/03/2024 02:54, Henry Wang wrote: > Currently direct mapped domain is only supported by the Arm > architecture at the domain creation time by setting the CDF_directmap > flag. There is not a need for every non-Arm architecture, i.e. x86, > RISC-V and PPC, to define a stub is_domain_direct_mapped() in arch > header. > > Move is_domain_direct_mapped() to a centralized place at xen/domain.h > and evaluate CDF_directmap for non-Arm architecture to 0. > > Signed-off-by: Henry Wang <xin.wa...@amd.com> Shouldn't you add Suggested-by: Jan?
Reviewed-by: Michal Orzel <michal.or...@amd.com> Another alternative would be to let the arch header define it if needed and use a centralized stub in xen/domain.h: #ifndef is_domain_direct_mapped #define is_domain_direct_mapped(d) ((void)(d), 0) #endif I'm not sure which solution is better. ~Michal
