On 08.03.2024 10:06, Henry Wang wrote: > On 3/8/2024 4:59 PM, Michal Orzel wrote: >> Another alternative would be to let the arch header define it if needed and >> use a centralized stub in xen/domain.h: >> >> #ifndef is_domain_direct_mapped >> #define is_domain_direct_mapped(d) ((void)(d), 0) >> #endif >> >> I'm not sure which solution is better. > > Thanks for the suggestion. I am fine with either way, so let's see what > the others would say and I will do the update of this patch accordingly.
While I wouldn't strictly mind the addition of an #ifdef, I'd prefer it to be omitted until such time when an arch would really want to override it. IOW patch as-is Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
