On 22.03.2023 08:32, Luca Fancellu wrote: > While I was browsing the code, I spotted a possible bug in x86/dom0_build.c, > in > parse_dom0_param(...) if an option is not recognised we set rc = -EINVAL, but > we don’t > stop the loop and we continue to parse. > Is it the intended behaviour?
My view: Yes. But I can see how one might look at this differently. Yet iirc the same behavior can be found elsewhere as well, e.g. for "spec-ctrl=". The goal is to parse everything we recognize, covering for people using options on older hypervisors which are supported only by newer ones. Jan
