Re: [PATCH v3 08/10] tools: add physinfo arch_capabilities handling for Arm

[Christian Lindig]

> On 17 Mar 2023, at 13:19, Luca Fancellu <luca.fance...@arm.com> wrote:
> 
> 
>       arch_cap_flags = caml_alloc_small(1, arch_cap_flags_tag);
>       Store_field(arch_cap_flags, 0, arch_cap_list);
>       Store_field(physinfo, 10, arch_cap_flags);
> +#elif defined(__aarch64__)
> +     Store_field(physinfo, 10, Val_int(c_physinfo.arch_capabilities));
> +#else
> +     caml_failwith("Unhandled architecture");
> +#endif
> 

Is this code overwriting an existing entry that was computed but now isn’t 
used? If so, should the conditional compilation not avoid this?

— C