On Wed, 2017-02-15 at 13:57 +0000, George Dunlap wrote: > On Thu, Feb 9, 2017 at 1:58 PM, Dario Faggioli > <dario.faggi...@citrix.com> wrote: > > > > Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> > > Acked-by: George Dunlap <george.dun...@citrix.com> > Thanks.
> With one comment...
>
> > diff --git a/xen/common/sched_credit2.c
> > b/xen/common/sched_credit2.c
> > index 786dcca..4b4f4f8 100644
> > --- a/xen/common/sched_credit2.c
> > +++ b/xen/common/sched_credit2.c
> > @@ -594,14 +594,12 @@ static s_time_t c2t(struct
> > csched2_runqueue_data *rqd, s_time_t credit, struct c
> > * Runqueue related code
> > */
> >
> > -static /*inline*/ int
> > -__vcpu_on_runq(struct csched2_vcpu *svc)
> > +static inline int vcpu_on_runq(struct csched2_vcpu *svc)
> > {
> > return !list_empty(&svc->runq_elem);
> > }
> >
> > -static /*inline*/ struct csched2_vcpu *
> > -__runq_elem(struct list_head *elem)
> > +static struct csched2_vcpu * runq_elem(struct list_head *elem)
> > {
> > return list_entry(elem, struct csched2_vcpu, runq_elem);
> > }
>
> Would it make sense to make this inline as well?
>
Absolutely (not sure why it wasn't! :-P)
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
