>>> On 09.02.17 at 14:58, <dario.faggi...@citrix.com> wrote: > +/* CPU to runq_id macro */ > +static always_inline int c2r(const struct scheduler *ops, unsigned cpu) > +{ > + return (csched2_priv(ops))->runq_map[(cpu)];
Any reason for having the (pointless) parentheses here but not ... > +} > + > +/* CPU to runqueue struct macro */ > +static always_inline > +struct csched2_runqueue_data *c2rqd(const struct scheduler *ops, unsigned > cpu) > +{ > + return &csched2_priv(ops)->rqd[c2r(ops, cpu)]; ... here? Also I'm not sure whether the sched*.c files are an exception, but generally we don't use plain "unsigned" but always "unsigned int". Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel