>>> On 09.02.17 at 15:14, <andrew.coop...@citrix.com> wrote: > On 09/02/17 13:58, Dario Faggioli wrote: >> +struct csched2_private *csched2_priv(const struct scheduler *ops) > > You should either return a const csched2_private *, or not take a const > ops. (Your choice.) > > Despite being allowed by the C typesystem, it is type (ab)use as it > changes the expectation of of what is meant by passing a const ops in > the first place.
That's debatable. I'd rather see csched2_vcpu() and csched2_dom() also be changed to match the above. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
