On Wed, 2017-02-15 at 10:49 +0000, George Dunlap wrote: > On Thu, Feb 9, 2017 at 3:33 PM, Dario Faggioli > <dario.faggi...@citrix.com> wrote: > > On Thu, 2017-02-09 at 07:36 -0700, Jan Beulich wrote: > > Nope. I'll get rid of them from above. > > > Also I'm not sure whether the sched*.c files are an exception, > > > but > > > generally we don't use plain "unsigned" but always "unsigned > > > int". > > > > > Yes, in sched_credit.c and sched_credit2.c there are a few > > unsigned. > > But I'm happy to use "unsigned int" for new code, such as here. > > FWIW I agree with Andy and Jan's comments. Everything else looks > good to me. > Err... So, I removed the pointless parentheses and I turned "unsigned" to "unsigned int".
As per consts, I agree with Jan, and hence I added the qualifier to the pointer arguments of csched2_dom() and csched2_vcpu(), as he suggested, without changing the return type. And I'm also using plain 'inline' rather than 'always_inline'. Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
