On Mon, 22 Dec 2025 14:43:41 GMT, Lois Foltan <[email protected]> wrote:
> LGTM. > > One nit at line #735 in classLoader.cpp, the convention within the file is to > specify the variable that you are checking nullptr against first, if > (preview_entry != nullptr)... > > Thanks, Lois I was just following what I saw code around doing (I don't know if you'd catch "(x = nullptr)" and assumed the reversed/"yoda" style was a guard against that. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1854#issuecomment-3683603422
