On Fri, 19 Dec 2025 15:42:24 GMT, David Beaumont <[email protected]> wrote:
>> Hopefully a fix for preview mode with exploded images in classLoader.cpp. >> >> I did a little renaming since now it's clear that "preview mode" isn't a >> thing that's limited only to a jimage being present. > > src/hotspot/share/classfile/classLoader.cpp line 999: > >> 997: } >> 998: >> 999: // caller needs ResourceMark > > Based on the code above. Both these should probably use stringStream and > format specifiers according to several people. I don't want to do that in > this PR though. As long as it doesn't have a buffer overrun, it's fine to fix later. It seems okay. > src/hotspot/share/classfile/classLoader.hpp line 252: > >> 250: static const char* file_name_for_class_name(const char* class_name, >> 251: int class_name_len); >> 252: // REVIEWER-NOTE: Where best to put this - it should be private! > > I don't think this should be here, but several other "private looking" > functions are in the public section so I'm not sure. Advice requested... Move it up to the private section. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1845#discussion_r2635737050 PR Review Comment: https://git.openjdk.org/valhalla/pull/1845#discussion_r2635574286
