On Fri, 19 Dec 2025 15:36:35 GMT, David Beaumont <[email protected]> wrote:

> Hopefully a fix for preview mode with exploded images in classLoader.cpp.
> 
> I did a little renaming since now it's clear that "preview mode" isn't a 
> thing that's limited only to a jimage being present.

src/hotspot/share/classfile/classLoader.cpp line 1077:

> 1075:     if (nullptr == stream) {
> 1076:       stream = e->open_stream(current, file_name);
> 1077:     }

Why not pass in the preview flag to search_module_entries (or use the global) 
and create and preview file name here?
Its better encapsulated, with a smaller scope knowing about META-INF.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1845#discussion_r2635601534

Reply via email to