On Sat, 20 Dec 2025 14:54:27 GMT, David Beaumont <[email protected]> wrote:
> Preview mode support for exploded build. > > This is an alternate approach from > https://github.com/openjdk/valhalla/pull/1845 which I think is actually > cleaner and more robust. LGTM. One nit at line #735 in classLoader.cpp, the convention within the file is to specify the variable that you are checking nullptr against first, if (preview_entry != nullptr)... Thanks, Lois Marked as reviewed by lfoltan (Committer). ------------- Marked as reviewed by lfoltan (Committer). PR Review: https://git.openjdk.org/valhalla/pull/1854#pullrequestreview-3604345803 PR Review: https://git.openjdk.org/valhalla/pull/1854#pullrequestreview-3604348116
