On Wed, 3 Sep 2025 15:58:04 GMT, Chen Liang <[email protected]> wrote:
>> Improve access flag reflection for preview on/off. >> >> In this process, I noted javac is incorrectly injecting ACC_IDENTITY to 69.0 >> class' `InnerClasses` attribute and fixed that. >> >> There is still some inconsistency, such as implying ACC_IDENTITY when >> preview is on for classes. Don't know if we have discussed on this yet. >> >> No new test failures. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 11 additional commits since > the last revision: > > - markedPreview handling > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > fix/preview-reflects > - Years > - Stage > - Stage > - Trivial > - Unit test > - Fix identity flag missing for preview inner classes > - Stage > - Fixes > - ... and 1 more: > https://git.openjdk.org/valhalla/compare/f4f8e1d8...94ee7a1e Marked as reviewed by mcimadamore (Committer). ------------- PR Review: https://git.openjdk.org/valhalla/pull/1533#pullrequestreview-3181344618
