On Wed, 3 Sep 2025 15:57:09 GMT, Chen Liang <[email protected]> wrote:
>> ACC_ ones are bit masks, and distinguishing them is meaningless. >> AccessFlag.IDENTITY and AccessFlag.SUPER are the actual differing ones. >> Validation of access flags by version requires somewhat invasive changes to >> the ClassFile API, so is not included in this patch. >> >> Reminder, this class building is completely in non-preview. There is no >> point talking about identity here. > > We can track making LMF/MHP value classes in > https://bugs.openjdk.org/browse/JDK-8205668 > ACC_ ones are bit masks, and distinguishing them is meaningless. > AccessFlag.IDENTITY and AccessFlag.SUPER are the actual differing ones. > Validation of access flags by version requires somewhat invasive changes to > the ClassFile API, so is not included in this patch. > > Reminder, this class building is completely in non-preview. There is no point > talking about identity here. Ok, I got confused, thought the code was using AccessFlag. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1533#discussion_r2319443201
