On Thu, 28 Aug 2025 23:03:11 GMT, Chen Liang <[email protected]> wrote:
>> Improve access flag reflection for preview on/off.
>>
>> In this process, I noted javac is incorrectly injecting ACC_IDENTITY to 69.0
>> class' `InnerClasses` attribute and fixed that.
>>
>> There is still some inconsistency, such as implying ACC_IDENTITY when
>> preview is on for classes. Don't know if we have discussed on this yet.
>>
>> No new test failures.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Years
src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line
1772:
> 1770: } else {
> 1771: poolbuf.appendChar(target.minorVersion);
> 1772: markedPreview = target.minorVersion ==
> ClassFile.PREVIEW_MINOR_VERSION;
I don't think `target.minorVersion` can ever be preview?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1533#discussion_r2313595881
