On Wed, 3 Sep 2025 14:15:35 GMT, Chen Liang <[email protected]> wrote:
>> Ok, but then shouldn't this add both ACC_IDENTITY and ACC_SUPER and leave it >> to the API to decide what to emit based on version? > > ACC_ ones are bit masks, and distinguishing them is meaningless. > AccessFlag.IDENTITY and AccessFlag.SUPER are the actual differing ones. > Validation of access flags by version requires somewhat invasive changes to > the ClassFile API, so is not included in this patch. > > Reminder, this class building is completely in non-preview. There is no point > talking about identity here. We can track making LMF/MHP value classes in https://bugs.openjdk.org/browse/JDK-8205668 ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1533#discussion_r2319423466
