On 08/09/2011 12:19, Adrian Gonzalez wrote: > Thanks Mark ! > >> It should be possible to cache the ValueExpression per JSP page (in the >> PageContext) > > Yes, but the PageContext life's span is more or less a user request, no ?
Correct. I should have said via the PageContext since that is all that is available at the point where the cache would be used. > In this case, ValueExpression caching will only be useful when exactly the > same expression is used multiple times in the same JSP. And I agree that we > are improving there a micro-benchmark. > > What I was thinking was more about caching ValueExpression per class of JSP > (i.e. one cache for edit_002dclassictag_jsp.java) - the cache being shared by > all users of the application. Agreed. > WDYT ? I think it is worth a try. I tried it and saw no improvement. If there was going to be any benefit then this use case is where I'd expect to see it so I think we can conclude there is little more to be done here. It appears the overhead of the cache is roughly the same as the overhead of creating the value expression (or both are so small that other factors are dominating). Mark --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
