Ouch, that was fast ! Thanks very much ! Are you willing to build Tomcat 7.0.x from source and see if the new cache works for you?
-> Of course ! Donno if I'm doing it now or tomorrow morning though - I'm a bit ill at the moment ;( sources are in trunk, right ? (http://svn.apache.org/repos/asf/tomcat/trunk/) ----- Mail original ----- De : Mark Thomas <ma...@apache.org> À : Tomcat Users List <users@tomcat.apache.org> Cc : Envoyé le : Mercredi 7 Septembre 2011 20h36 Objet : Re: Re : Performance issue in simpleTags and tagfiles On 07/09/2011 18:37, Adrian Gonzalez wrote: > Thanks for taking your time to look this issue ! Adding a cache for annotation scanning (that was taking most of the time) was relatively simple. Are you willing to build Tomcat 7.0.x from source and see if the new cache works for you? Mark > ----- Mail original ----- > De : Mark Thomas <ma...@apache.org> > À : Tomcat Users List <users@tomcat.apache.org> > Cc : > Envoyé le : Mercredi 7 Septembre 2011 19h13 > Objet : Re: Performance issue in simpleTags and tagfiles > > On 07/09/2011 15:57, Remy Maucherat wrote: >> On Wed, Sep 7, 2011 at 2:23 PM, Adrian Gonzalez <adr_gonza...@yahoo.fr> >> wrote: >>> Hello, >>> >>> I've noticed a performance difference between classic Tags and simple Tags >>> in Tomcat 7.0.21 (also tested it on 7.0.6 with the same results). >>> >>> Simple tags or tagfiles execution is at 5 times superior to classic tag >>> execution. >> >> Simple tags (and derivatives) are easier to write, but are not >> poolable. So regular tags are best if you're going to use them a lot. > > +1 > > A look with a profiler shows that a fair amount of time is spend in the > InstanceManager with the non-poolable tags. We could probably speed that > up with some caching. > > I'll take a look to see if the benefit is worth the complexity. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org For additional commands, e-mail: users-h...@tomcat.apache.org
